Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1394433004: Try again to fix the links in the GN README.md. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
tfarina, nodir
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try again to fix the links in the GN README.md. Turns out that gitiles is even more broken than I thought, and using absolute paths for links doesn't work either. This patch changes the links in GN's README.md to use full URLs instead. TBR=nodir@chromium.org BUG= Committed: https://crrev.com/c8bcd19882e5f0ba62badf0ebd2efde625531c7e Cr-Commit-Position: refs/heads/master@{#353682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tools/gn/README.md View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-13 04:54:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394433004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394433004/1
5 years, 2 months ago (2015-10-13 04:54:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 05:06:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8bcd19882e5f0ba62badf0ebd2efde625531c7e Cr-Commit-Position: refs/heads/master@{#353682}
5 years, 2 months ago (2015-10-13 05:07:33 UTC) #5
tfarina
5 years, 2 months ago (2015-10-13 05:14:13 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698