Password sync refactoring: implemented ProcessSyncChanges() and GetAllSyncData()

chrome/browser/password_manager/password_syncable_service.cc

Index: chrome/browser/password_manager/password_syncable_service.cc
diff --git a/chrome/browser/password_manager/password_syncable_service.cc b/chrome/browser/password_manager/password_syncable_service.cc
index aa4b3aaf14921b1ff13a9288406f2ea41be08715..a235cd9b430eed22c379191ef1ff08b715ea08b0 100644
--- a/chrome/browser/password_manager/password_syncable_service.cc
+++ b/chrome/browser/password_manager/password_syncable_service.cc
@@ -114,30 +114,19 @@ syncer::SyncMergeResult PasswordSyncableService::MergeDataAndStartSyncing(
   sync_error_factory_ = sync_error_factory.Pass();
   sync_processor_ = sync_processor.Pass();
 
+  // We add all the db entries as |new_local_entries| initially. During model
+  // association entries that match a sync entry will be removed and this list
+  // will only contain entries that are not in sync.
   ScopedVector<autofill::PasswordForm> password_entries;
-  if (!password_store_->FillAutofillableLogins(&password_entries.get())) {
-    // Password store often fails to load passwords. Track failures with UMA.
-    // (http://crbug.com/249000)
-    UMA_HISTOGRAM_ENUMERATION("Sync.LocalDataFailedToLoad",
-                              syncer::PASSWORDS,
-                              syncer::MODEL_TYPE_COUNT);
+  PasswordEntryMap new_local_entries;
+  if (!ReadFromPasswordStore(&password_entries, &new_local_entries)) {
+    DCHECK(sync_error_factory_);
     merge_result.set_error(sync_error_factory_->CreateAndUploadError(
         FROM_HERE,
         "Failed to get passwords from store."));
     return merge_result;
   }
 
-  PasswordEntryMap new_local_entries;
-  for (PasswordForms::iterator it = password_entries.begin();
-       it != password_entries.end(); ++it) {
-     autofill::PasswordForm* password_form = *it;
-     // We add all the db entries as |new_local_entries| initially. During
-     // model association entries that match a sync entry will be
-     // removed and this list will only contain entries that are not in sync.
-     new_local_entries.insert(
-         std::make_pair(MakePasswordSyncTag(*password_form), password_form));
-  }
-
   merge_result.set_num_items_before_association(new_local_entries.size());
 
   // List that contains the entries that are known only to sync.
@@ -160,7 +149,8 @@ syncer::SyncMergeResult PasswordSyncableService::MergeDataAndStartSyncing(
   }
 
   WriteToPasswordStore(new_sync_entries.get(),
-                       updated_sync_entries.get());
+                       updated_sync_entries.get(),
+                       PasswordForms());
 
   merge_result.set_num_items_after_association(
       merge_result.num_items_before_association() + new_sync_entries.size());
@@ -190,18 +180,82 @@ void PasswordSyncableService::StopSyncing(syncer::ModelType type) {
 
 syncer::SyncDataList PasswordSyncableService::GetAllSyncData(
     syncer::ModelType type) const {
+  DCHECK_EQ(syncer::PASSWORDS, type);
+  ScopedVector<autofill::PasswordForm> password_entries;
+  ReadFromPasswordStore(&password_entries, NULL);
+
   syncer::SyncDataList sync_data;
+  for (PasswordForms::iterator it = password_entries.begin();
+       it != password_entries.end(); ++it) {
+    sync_data.push_back(SyncDataFromPassword(**it));
+  }
   return sync_data;
 }
 
 syncer::SyncError PasswordSyncableService::ProcessSyncChanges(
     const tracked_objects::Location& from_here,
     const syncer::SyncChangeList& change_list) {
-  syncer::SyncError error(FROM_HERE,
-                          syncer::SyncError::UNRECOVERABLE_ERROR,
-                          "Password Syncable Service Not Implemented.",
-                          syncer::PASSWORDS);
-  return error;
+  // The |db_entries_map| and associated vectors are filled only in case of
+  // add/update change.

[Ilya Sherman, 2014/02/11 07:59:46]

nit: Now only on an update change, right?

[vasilii, 2014/02/11 12:23:33]

Done.

+  PasswordEntryMap db_entries_map;
+  ScopedVector<autofill::PasswordForm> password_db_entries;
+  ScopedVector<autofill::PasswordForm> new_sync_entries;
+  ScopedVector<autofill::PasswordForm> updated_sync_entries;
+  ScopedVector<autofill::PasswordForm> deleted_entries;
+  bool has_read_passwords = false;
+
+  for (syncer::SyncChangeList::const_iterator it = change_list.begin();
+       it != change_list.end();
+       ++it) {
+    switch (it->change_type()) {
+      case syncer::SyncChange::ACTION_ADD: {
+        const sync_pb::EntitySpecifics& specifics =
+            it->sync_data().GetSpecifics();
+        new_sync_entries.push_back(new autofill::PasswordForm);
+        PasswordFromSpecifics(specifics.password().client_only_encrypted_data(),
+                              new_sync_entries.back());
+        break;
+      }
+      case syncer::SyncChange::ACTION_UPDATE: {
+        if (!has_read_passwords) {
+          if (ReadFromPasswordStore(&password_db_entries,
+                                    &db_entries_map)) {
+            has_read_passwords = true;
+          } else {
+            return sync_error_factory_->CreateAndUploadError(
+                FROM_HERE,
+                "Failed to get passwords from store.");
+          }
+        }
+        syncer::SyncChangeList sync_changes;
+
+        CreateOrUpdateEntry(it->sync_data(),
+                            &db_entries_map,
+                            &new_sync_entries,
+                            &updated_sync_entries,
+                            &sync_changes);

[Ilya Sherman, 2014/02/11 07:59:46]

Would be nice to DCHECK that sync_changes remains empty after this call.

[vasilii, 2014/02/11 12:23:33]

CreateOrUpdateEntry() is written in the way that it pushes updates to both sync
and local db. Do you think it should be fixed?

[Ilya Sherman, 2014/02/11 21:58:25]

Ah.  Yes, I do think it should be fixed -- it's unnecessary to generate the
extra updates, and it can make invariants like this one clearer.

[vasilii, 2014/02/12 13:27:12]

Done.

[Ilya Sherman, 2014/02/12 22:58:50]

Thanks!  (Still LGTM, so the CQ doesn't freak out.)

+        break;
+      }
+
+      case syncer::SyncChange::ACTION_DELETE: {
+        const sync_pb::EntitySpecifics& specifics =
+            it->sync_data().GetSpecifics();
+        const sync_pb::PasswordSpecificsData& password_specifics(
+            specifics.password().client_only_encrypted_data());
+        deleted_entries.push_back(new autofill::PasswordForm);
+        PasswordFromSpecifics(password_specifics, deleted_entries.back());
+        break;
+      }
+      case syncer::SyncChange::ACTION_INVALID:
+        return sync_error_factory_->CreateAndUploadError(
+            FROM_HERE,
+            "Failed to process sync changes for passwords datatype.");
+    }
+  }
+  WriteToPasswordStore(new_sync_entries.get(),
+                       updated_sync_entries.get(),
+                       deleted_entries.get());
+  return syncer::SyncError();
 }
 
 void PasswordSyncableService::ActOnPasswordStoreChanges(
@@ -220,9 +274,37 @@ void PasswordSyncableService::ActOnPasswordStoreChanges(
   sync_processor_->ProcessSyncChanges(FROM_HERE, sync_changes);
 }
 
+bool PasswordSyncableService::ReadFromPasswordStore(
+    ScopedVector<autofill::PasswordForm>* password_entries,
+    PasswordEntryMap* passwords_entry_map) const {
+  DCHECK(password_entries);
+  if (!password_store_->FillAutofillableLogins(&password_entries->get()) ||
+      !password_store_->FillBlacklistLogins(&password_entries->get())) {
+    // Password store often fails to load passwords. Track failures with UMA.
+    // (http://crbug.com/249000)
+    UMA_HISTOGRAM_ENUMERATION("Sync.LocalDataFailedToLoad",
+                              ModelTypeToHistogramInt(syncer::PASSWORDS),
+                              syncer::MODEL_TYPE_COUNT);
+    return false;
+  }
+
+  if (!passwords_entry_map)
+    return true;
+
+  for (PasswordForms::iterator it = password_entries->begin();
+       it != password_entries->end(); ++it) {
+     autofill::PasswordForm* password_form = *it;
+     passwords_entry_map->insert(
+         std::make_pair(MakePasswordSyncTag(*password_form), password_form));
+  }
+
+  return true;
+}
+
 void PasswordSyncableService::WriteToPasswordStore(
     const PasswordForms& new_entries,
-    const PasswordForms& updated_entries) {
+    const PasswordForms& updated_entries,
+    const PasswordForms& deleted_entries) {
   PasswordStoreChangeList changes;
   for (std::vector<autofill::PasswordForm*>::const_iterator it =
            new_entries.begin();
@@ -238,6 +320,13 @@ void PasswordSyncableService::WriteToPasswordStore(
     AppendChanges(password_store_->UpdateLoginImpl(**it), &changes);
   }
 
+  for (std::vector<autofill::PasswordForm*>::const_iterator it =
+           deleted_entries.begin();
+       it != deleted_entries.end();
+       ++it) {
+    AppendChanges(password_store_->RemoveLoginImpl(**it), &changes);
+  }
+
   // We have to notify password store observers of the change by hand since
   // we use internal password store interfaces to make changes synchronously.
   NotifyPasswordStoreOfLoginChanges(changes);