Password sync refactoring: implemented ProcessSyncChanges() and GetAllSyncData()

chrome/browser/password_manager/password_syncable_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_SYNCABLE_SERVICE_H__
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_SYNCABLE_SERVICE_H__
 
 #include <string>
 #include <vector>
 
@@ skipping 38 matching lines @@
       syncer::ModelType type) const OVERRIDE;
   virtual syncer::SyncError ProcessSyncChanges(
       const tracked_objects::Location& from_here,
       const syncer::SyncChangeList& change_list) OVERRIDE;
 
   // Notifies sync of changes to the password database.
   void ActOnPasswordStoreChanges(const PasswordStoreChangeList& changes);
 
  private:
   typedef std::vector<autofill::PasswordForm*> PasswordForms;
+  // Map from password sync tag to password form.
   typedef std::map<std::string, autofill::PasswordForm*> PasswordEntryMap;
 
-  // Use the |PasswordStore| APIs to add and update entries.
+  // Helper function to retrieve the entries from password db and fill both
+  // |password_entries| and |passwords_entry_map|. |passwords_entry_map| can be
+  // NULL.
+  bool ReadFromPasswordStore(
+      ScopedVector<autofill::PasswordForm>* password_entries,
+      PasswordEntryMap* passwords_entry_map) const;
+
+  // Uses the |PasswordStore| APIs to change entries.
   void WriteToPasswordStore(const PasswordForms& new_entries,
-                            const PasswordForms& updated_entries);
+                            const PasswordForms& updated_entries,
+                            const PasswordForms& deleted_entries);
 
   // Notifies password store of a change that was performed by sync.
   // Virtual so tests can override.
   virtual void NotifyPasswordStoreOfLoginChanges(
       const PasswordStoreChangeList& changes);
 
   // Checks if |data|, the entry in sync db, needs to be created or updated
   // in the passwords db. Depending on what action needs to be performed, the
   // entry may be added to |new_sync_entries| or to |updated_sync_entries|. If
   // the item is identical to an entry in the passwords db, no action is
@@ skipping 24 matching lines @@
 
 // Extracts the |PasswordForm| data from sync's protobuffer format.
 void PasswordFromSpecifics(const sync_pb::PasswordSpecificsData& password,
                            autofill::PasswordForm* new_password);
 
 // Returns the unique tag that will serve as the sync identifier for the
 // |password| entry.
 std::string MakePasswordSyncTag(const sync_pb::PasswordSpecificsData& password);
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_SYNCABLE_SERVICE_H__