chrome/app/generated_resources.grd - Issue 1394423004: Initial skeleton of custom layouts for Web Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Issue 1394423004: Initial skeleton of custom layouts for Web Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix v17 styles and add entries to LoginCustomFlags. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('k') | chrome/browser/about_flags.cc » ('j') | chrome/common/chrome_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 9e7dd13a819d65d9f875ab96be6bbc77d2d79060..43c3b77f904217874686a0cb1c4511a2395a7412 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -12598,6 +12598,12 @@ Some features may be unavailable. Please check that the profile exists and you

Turn off these notifications

</message>

+ <message name="IDS_FLAGS_ENABLE_NOTIFICATIONS_CUSTOM_LAYOUTS_NAME" desc="Name of the flag to enable custom layouts for Web Notifications.">

+ Enable custom layouts for the Notifications API

Peter Beverloo 2015/10/12 14:08:30 You refer to the feature in three different ways:

Michael van Ouwerkerk 2015/10/12 17:10:59 I went for "web notification custom layouts" as it

+ </message>

+ <message name="IDS_FLAGS_ENABLE_NOTIFICATIONS_CUSTOM_LAYOUTS_DESCRIPTION" desc="Description for the flag to enable custom layouts for Web Notifications.">

+ Enable custom layouts for the Notifications API. They will have subtle layout improvements that are otherwise not possible.

+ </message>

</if>