Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1394403004: Provide functionality in the dxva decoder on Windows to use the angle created device object if poss… (Closed)

Created:
5 years, 2 months ago by ananta
Modified:
5 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide functionality in the dxva decoder on Windows to use the angle created device object if possible. This uses the angle provided extensions to query the device object. This is used by default now if DX11 is enabled and for D3D9 when the disable-d3d11 flag is passed in. The idea behind using angle's device is that it will improve playback performance by eliminating copies across devices. This is based on the work which sandersd initially started. BUG=337606 Committed: https://crrev.com/1cef88d98d7777b826cb076b1e20f9874bb3cf57 Cr-Commit-Position: refs/heads/master@{#355477}

Patch Set 1 #

Patch Set 2 : Ensure that the d3d9 instance is created #

Patch Set 3 : Restore DCHECK for video_frame #

Total comments: 2

Patch Set 4 : Fix error messages in the QueryDeviceObjectFromANGLE function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -54 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 2 3 4 chunks +113 lines, -54 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (2 generated)
ananta
5 years, 2 months ago (2015-10-10 02:08:24 UTC) #2
sandersd (OOO until July 31)
When I tried this, I wasn't able to use the D3D11 device for decoding. I ...
5 years, 2 months ago (2015-10-12 18:44:03 UTC) #3
ananta
I tested this on Windows 8 and Windows 10. On Windows 7 the angle device ...
5 years, 2 months ago (2015-10-12 22:18:15 UTC) #4
sandersd (OOO until July 31)
LGTM.
5 years, 2 months ago (2015-10-12 22:27:06 UTC) #5
ananta
On 2015/10/12 22:27:06, sandersd wrote: > LGTM. Thanks. Dale is on vacation till Oct 16th. ...
5 years, 2 months ago (2015-10-12 23:56:26 UTC) #6
ananta
On 2015/10/12 22:27:06, sandersd wrote: > LGTM. Thanks. Dale is on vacation till Oct 16th. ...
5 years, 2 months ago (2015-10-12 23:56:27 UTC) #7
sandersd (OOO until July 31)
On 2015/10/12 23:56:27, ananta wrote: > On 2015/10/12 22:27:06, sandersd wrote: > > LGTM. > ...
5 years, 2 months ago (2015-10-13 00:24:47 UTC) #8
ananta
On 2015/10/13 00:24:47, sandersd wrote: > On 2015/10/12 23:56:27, ananta wrote: > > On 2015/10/12 ...
5 years, 2 months ago (2015-10-13 00:48:08 UTC) #9
sandersd (OOO until July 31)
On 2015/10/13 00:48:08, ananta wrote: > On 2015/10/13 00:24:47, sandersd wrote: > > On 2015/10/12 ...
5 years, 2 months ago (2015-10-13 01:27:27 UTC) #10
DaleCurtis
lgtm
5 years, 2 months ago (2015-10-22 00:40:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394403004/20002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394403004/20002
5 years, 2 months ago (2015-10-22 00:50:32 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:20002)
5 years, 2 months ago (2015-10-22 02:18:12 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 02:19:06 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1cef88d98d7777b826cb076b1e20f9874bb3cf57
Cr-Commit-Position: refs/heads/master@{#355477}

Powered by Google App Engine
This is Rietveld 408576698