cc/proto/point.proto - Issue 1394353002: Add Protobuf support in cc for gfx objects

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/proto/point.proto

Issue 1394353002: Add Protobuf support in cc for gfx objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build for other targets Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //

5 // Common message types for sharing across Blimp subprotocols.

6	4

7 syntax = "proto2";	5 syntax = "proto2";

8	6

9 option optimize_for = LITE_RUNTIME;	7 option optimize_for = LITE_RUNTIME;

10	8

11 package blimp;	9 package cc.proto;

12	10

13 message CoordinatePair {	11 message Point {

14 optional sint32 x = 1;	12 optional int32 x = 1;
	danakj 2015/10/14 22:42:37 Is it not problematic that int inside Point can be Is it not problematic that int inside Point can be bigger than 32 bits? David Trainor- moved to gerrit 2015/10/14 22:57:51 Oops good point :(. Thanks! Changed size too and Show quoted text On 2015/10/14 22:42:37, danakj wrote: > Is it not problematic that int inside Point can be bigger than 32 bits? Oops good point :(. Thanks! Changed size too and added a unit test against std::numeric_limits<int> (I think that should test those cases).
15 optional sint32 y = 2;	13 optional int32 y = 2;
	danakj 2015/10/14 23:10:10 why are these all optional? (i'm a noob here) why are these all optional? (i'm a noob here) David Trainor- moved to gerrit 2015/10/15 22:18:02 It's a general rule to never make something requir Show quoted text On 2015/10/14 23:10:10, danakj wrote: > why are these all optional? (i'm a noob here) It's a general rule to never make something required with protobufs. If you do, you can't ever do versioning control and omit the field in the future.
16 }	14 }

17

OLD	NEW

« cc/proto/gfx_conversions_unittest.cc ('K') | « cc/proto/gfx_conversions_unittest.cc ('k') | cc/proto/pointf.proto » ('j') | ui/gfx/gfx.gyp » ('J')