Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1394343005: Fix path to binary dir in cdb test (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Fix path to binary dir in cdb test Oops, was passing the out dir (...\crashpad\out), not the binary dir (...\crashpad\out\Debug). Didn't notice because I was running the script directly, rather than via run_tests.py. :/ R=mark@chromium.org BUG=crashpad:46 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d7ee79cb362e55a40532c514e300b830fd7fc307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/win/end_to_end_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
5 years, 2 months ago (2015-10-09 21:10:04 UTC) #1
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-09 21:23:07 UTC) #2
scottmg
5 years, 2 months ago (2015-10-09 21:43:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7ee79cb362e55a40532c514e300b830fd7fc307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698