Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1394303003: Revert of Use simple/fast macro version of MinMax in JS (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use simple/fast macro version of MinMax in JS (patchset #2 id:20001 of https://codereview.chromium.org/1390023003/ ) Reason for revert: This contains bugs, as found by mstarzinger. Reverting until we can find a clean fix (maybe it should be an inline function instead of a macro). Original issue's description: > Use simple/fast macro version of MinMax in JS > > Use the simple macro version of {Min, Max} where possible to > improve performance > > Follow-up to CR: https://codereview.chromium.org/1331993004 > > BUG= > > Committed: https://crrev.com/27c96c26212a10bb7f19f7bf3ff793b31bbad354 > Cr-Commit-Position: refs/heads/master@{#31162} TBR=jkummerow@chromium.org,mstarzinger@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a01ab93f4cc221c1bf7df8e3f6724505b89af761 Cr-Commit-Position: refs/heads/master@{#31187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -28 lines) Patch
M src/array.js View 3 chunks +3 lines, -1 line 0 comments Download
M src/arraybuffer.js View 2 chunks +11 lines, -4 lines 0 comments Download
M src/harmony-array.js View 2 chunks +16 lines, -12 lines 0 comments Download
M src/harmony-atomics.js View 3 chunks +8 lines, -3 lines 0 comments Download
M src/harmony-typedarray.js View 4 chunks +11 lines, -7 lines 0 comments Download
M src/json.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Ehrenberg
Created Revert of Use simple/fast macro version of MinMax in JS
5 years, 2 months ago (2015-10-08 20:37:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394303003/1
5 years, 2 months ago (2015-10-08 20:37:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 20:37:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a01ab93f4cc221c1bf7df8e3f6724505b89af761 Cr-Commit-Position: refs/heads/master@{#31187}
5 years, 2 months ago (2015-10-08 20:38:19 UTC) #4
Jakob Kummerow
5 years, 2 months ago (2015-10-09 09:43:12 UTC) #5
Message was sent while issue was closed.
ACK, LGTM.

Powered by Google App Engine
This is Rietveld 408576698