Source/core/css/StyleResolver.cpp - Issue 13943004: Avoid reparsing keyframe selectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StyleResolver.cpp

Issue 13943004: Avoid reparsing keyframe selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/StyleResolver.cpp

diff --git a/Source/core/css/StyleResolver.cpp b/Source/core/css/StyleResolver.cpp

index 8eb283c39fb220c193d9fbf23f2b1bbe8b2af7ed..ec88be0aa82cb91463341679eb3e5b9545a62644 100644

--- a/Source/core/css/StyleResolver.cpp

+++ b/Source/core/css/StyleResolver.cpp

@@ -1098,8 +1098,7 @@ void StyleResolver::keyframeStylesForAnimation(Element* e, const RenderStyle* el

keyframeValue.setStyle(styleForKeyframe(elementStyle, keyframe, keyframeValue));

// Add this keyframe style to all the indicated key times

- Vector<float> keys;

- keyframe->getKeys(keys);

+ Vector<float> keys = keyframe->getKeys();

for (size_t keyIndex = 0; keyIndex < keys.size(); ++keyIndex) {

keyframeValue.setKey(keys[keyIndex]);

list.insert(keyframeValue);