Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 13943004: Avoid reparsing keyframe selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 1167 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 for (unsigned i = 0; i < keyframes.size(); ++i) { 1178 for (unsigned i = 0; i < keyframes.size(); ++i) {
1179 // Apply the declaration to the style. This is a simplified version of t he logic in styleForElement 1179 // Apply the declaration to the style. This is a simplified version of t he logic in styleForElement
1180 m_state.initForStyleResolve(document(), e); 1180 m_state.initForStyleResolve(document(), e);
1181 1181
1182 const StyleKeyframe* keyframe = keyframes[i].get(); 1182 const StyleKeyframe* keyframe = keyframes[i].get();
1183 1183
1184 KeyframeValue keyframeValue(0, 0); 1184 KeyframeValue keyframeValue(0, 0);
1185 keyframeValue.setStyle(styleForKeyframe(elementStyle, keyframe, keyframe Value)); 1185 keyframeValue.setStyle(styleForKeyframe(elementStyle, keyframe, keyframe Value));
1186 1186
1187 // Add this keyframe style to all the indicated key times 1187 // Add this keyframe style to all the indicated key times
1188 Vector<float> keys; 1188 const Vector<float>& keys = keyframe->keys();
1189 keyframe->getKeys(keys);
1190 for (size_t keyIndex = 0; keyIndex < keys.size(); ++keyIndex) { 1189 for (size_t keyIndex = 0; keyIndex < keys.size(); ++keyIndex) {
1191 keyframeValue.setKey(keys[keyIndex]); 1190 keyframeValue.setKey(keys[keyIndex]);
1192 list.insert(keyframeValue); 1191 list.insert(keyframeValue);
1193 } 1192 }
1194 } 1193 }
1195 1194
1196 // If the 0% keyframe is missing, create it (but only if there is at least o ne other keyframe) 1195 // If the 0% keyframe is missing, create it (but only if there is at least o ne other keyframe)
1197 int initialListSize = list.size(); 1196 int initialListSize = list.size();
1198 if (initialListSize > 0 && list[0].key()) { 1197 if (initialListSize > 0 && list[0].key()) {
1199 static StyleKeyframe* zeroPercentKeyframe; 1198 static StyleKeyframe* zeroPercentKeyframe;
(...skipping 2237 matching lines...) Expand 10 before | Expand all | Expand 10 after
3437 info.addMember(m_state, "state"); 3436 info.addMember(m_state, "state");
3438 3437
3439 // FIXME: move this to a place where it would be called only once? 3438 // FIXME: move this to a place where it would be called only once?
3440 info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle"); 3439 info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle");
3441 info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyl e"); 3440 info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyl e");
3442 info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle" ); 3441 info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle" );
3443 info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSo urceStyle"); 3442 info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSo urceStyle");
3444 } 3443 }
3445 3444
3446 } // namespace WebCore 3445 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/CSSParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698