Avoid reparsing keyframe selectors

Source/core/css/CSSKeyframeRule.h

 /*
  * Copyright (C) 2007, 2008, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 27 matching lines @@
 
 class StyleKeyframe : public RefCounted<StyleKeyframe> {
     WTF_MAKE_FAST_ALLOCATED;
 public:
     static PassRefPtr<StyleKeyframe> create()
     {
         return adoptRef(new StyleKeyframe());
     }
     ~StyleKeyframe();
 
-    String keyText() const { return m_key; }
-    void setKeyText(const String& s) { m_key = s; }
+    String keyText() const;
+    void setKeyText(const String&);
+    void setKeys(const Vector<float>&);
 
-    void getKeys(Vector<float>& keys) const   { parseKeyString(m_key, keys); }
+    Vector<float> getKeys() const { return m_keys; }

[apavlov, 2013/06/26 10:45:40]

This should also be
const Vector<float>& getKeys() const (returning a reference)
to avoid Vector copies.

 
     const StylePropertySet* properties() const { return m_properties.get(); }
     MutableStylePropertySet* mutableProperties();
     void setProperties(PassRefPtr<StylePropertySet>);
 
     String cssText() const;
 
     void reportMemoryUsage(MemoryObjectInfo*) const;
 
 private:
     StyleKeyframe();
 
-    static void parseKeyString(const String&, Vector<float>& keys);
+    static void parseKeyString(const String&, Vector<float>&);
 
     RefPtr<StylePropertySet> m_properties;
-    // FIXME: This should be a parsed vector of floats.
-    // comma separated list of keys
-    String m_key;
+    mutable String m_keyText;
+    Vector<float> m_keys;
 };
 
 class CSSKeyframeRule : public CSSRule {
 public:
     virtual ~CSSKeyframeRule();
 
     virtual CSSRule::Type type() const OVERRIDE { return WEBKIT_KEYFRAME_RULE; }
     virtual String cssText() const OVERRIDE { return m_keyframe->cssText(); }
     virtual void reattach(StyleRuleBase*) OVERRIDE;
     virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;
 
     String keyText() const { return m_keyframe->keyText(); }
     void setKeyText(const String& s) { m_keyframe->setKeyText(s); }
 
     CSSStyleDeclaration* style() const;
 
 private:
     CSSKeyframeRule(StyleKeyframe*, CSSKeyframesRule* parent);
 
     RefPtr<StyleKeyframe> m_keyframe;
     mutable RefPtr<StyleRuleCSSStyleDeclaration> m_propertiesCSSOMWrapper;
 
     friend class CSSKeyframesRule;
 };
 
 } // namespace WebCore
 
 #endif // CSSKeyframeRule_h