Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394283003: Move more extensions code into ChromeExtensionsRendererClient. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more extensions code into ChromeExtensionsRendererClient. Committed: https://crrev.com/587ab614970d60f687ea653444265fcb111ad347 Cr-Commit-Position: refs/heads/master@{#354921}

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -293 lines) Patch
M chrome/common/extensions/extension_process_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 5 chunks +1 line, -39 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 22 chunks +27 lines, -245 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.h View 1 2 2 chunks +63 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.cc View 1 2 chunks +277 lines, -0 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 4 chunks +15 lines, -3 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 2 months ago (2015-10-15 20:14:08 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 2 months ago (2015-10-19 21:47:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394283003/40001
5 years, 2 months ago (2015-10-19 22:43:11 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-20 00:10:08 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 00:10:42 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/587ab614970d60f687ea653444265fcb111ad347
Cr-Commit-Position: refs/heads/master@{#354921}

Powered by Google App Engine
This is Rietveld 408576698