pkg/compiler/lib/src/js_emitter/metadata_collector.dart - Issue 1394213002: Split RuntimesTypes into RuntimeTypes and RuntimeTypesEncoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

Issue 1394213002: Split RuntimesTypes into RuntimeTypes and RuntimeTypesEncoder (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

diff --git a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart

index e0a9b03bec7de32797f526f4af0fef9661fd6c5f..43aa5289bd00491f6085498a11588c7f13612e2b 100644

--- a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart

+++ b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart

@@ -243,7 +243,7 @@ class MetadataCollector implements jsAst.TokenFinalizer {

jsAst.Expression _computeTypeRepresentation(DartType type,

{ignoreTypeVariables: false}) {

- jsAst.Expression representation = _backend.rti.getTypeRepresentation(

+ jsAst.Expression representation = _backend.rtiEncoder.getTypeRepresentation(

type,

(variable) {

if (ignoreTypeVariables) return new jsAst.LiteralNull();