Split RuntimesTypes into RuntimeTypes and RuntimeTypesEncoder

Split RuntimesTypes into RuntimeTypes and RuntimeTypesEncoder

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/da0a18de447fb5d78e71708d2c5ea439fac14503

[Johnni Winther, 2015-10-08 10:10:36]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[Johnni Winther, 2015-10-08 10:10:37]

Main changes in runtime_types.dart

[karlklose, 2015-10-08 10:28:13]

LGTM!

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:18: abstract class
RuntimeTypes {
Maybe rename to something like RuntimeTypeUsageCollector?

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:52: Set<ClassElement>
getRequiredArgumentClasses(JavaScriptBackend backend);
Please add a comment to this function.

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:53: 
Remove extra new line.

[Johnni Winther, 2015-10-08 11:59:25]

Committed patchset #2 (id:20001) manually as
da0a18de447fb5d78e71708d2c5ea439fac14503 (presubmit successful).

[Johnni Winther, 2015-10-08 13:14:19]

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:18: abstract class
RuntimeTypes {
On 2015/10/08 10:28:12, karlklose wrote:
> Maybe rename to something like RuntimeTypeUsageCollector?

Added a TODO.

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:52: Set<ClassElement>
getRequiredArgumentClasses(JavaScriptBackend backend);
On 2015/10/08 10:28:12, karlklose wrote:
> Please add a comment to this function.

If only I knew what it did ;)

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:53: 
On 2015/10/08 10:28:12, karlklose wrote:
> Remove extra new line.

Done.

[karlklose, 2015-10-09 07:42:01]

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/1394213002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/runtime_types.dart:52: Set<ClassElement>
getRequiredArgumentClasses(JavaScriptBackend backend);
On 2015/10/08 13:14:19, Johnni Winther wrote:
> On 2015/10/08 10:28:12, karlklose wrote:
> > Please add a comment to this function.
> 
> If only I knew what it did ;)

I think it computes the set of classes that are mentioned in substitution
functions - we need to emit JS classes for them even if they are not live.