Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1394203003: Fix -Wunused-function error in native_stack_sampler_win.cc (Closed)

Created:
5 years, 2 months ago by hans
Modified:
5 years, 2 months ago
Reviewers:
Mike Wittman, wittman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix -Wunused-function error in native_stack_sampler_win.cc This was breaking Windows Clang builds: ..\..\base\profiler\native_stack_sampler_win.cc(82,6) : error: unused function 'RewritePointerIfInOriginalStack' [-Werror,-Wunused-function] void RewritePointerIfInOriginalStack(uintptr_t top, uintptr_t bottom, ^ BUG=82385 TBR=wittman Committed: https://chromium.googlesource.com/chromium/src/+/afed53480839e71ad84de41dfdaa5aacf6b559f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/profiler/native_stack_sampler_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/afed53480839e71ad84de41dfdaa5aacf6b559f8 Cr-Commit-Position: refs/heads/master@{#353063}
5 years, 2 months ago (2015-10-08 15:47:38 UTC) #1
hans
Committed patchset #1 (id:1) manually as afed53480839e71ad84de41dfdaa5aacf6b559f8 (presubmit successful).
5 years, 2 months ago (2015-10-08 15:48:00 UTC) #2
Mike Wittman
5 years, 2 months ago (2015-10-08 16:34:45 UTC) #3
Message was sent while issue was closed.
lgtm

Thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698