Issue 1394183005: Fix review nits that were missed from https://crrev.com/d7241e515462c10b29a0470c3c3df647ae34be4b.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1394183005: Fix review nits that were missed from https://crrev.com/d7241e515462c10b29a0470c3c3df647ae34be4b. (Closed)

Created:
5 years, 2 months ago by tfarina

Modified:
5 years, 2 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix review nits that were missed from https://crrev.com/d7241e515462c10b29a0470c3c3df647ae34be4b. * net_util.h include is not necessary. * || around text. BUG=488531 R=pkasting@chromium.org Committed: https://crrev.com/a041781bbee6ef43cb4680a9607a7372da6f6540 Cr-Commit-Position: refs/heads/master@{#353476}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	components/search_engines/template_url.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	components/url_formatter/url_formatter.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394183005/1

5 years, 2 months ago (2015-10-11 16:10:39 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-11 20:21:24 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a041781bbee6ef43cb4680a9607a7372da6f6540
Cr-Commit-Position: refs/heads/master@{#353476}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages