Issue 139413003: Replace the gc extension in content shell with a gin::Wrappable class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139413003: Replace the gc extension in content shell with a gin::Wrappable class (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
dcarney

CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace the gc extension in content shell with a gin::Wrappable class BUG=334679 R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245258

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -57 lines)			Patch
M	content/content_shell.gypi	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A +	content/shell/renderer/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	content/shell/renderer/gc_controller.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
A	content/shell/renderer/gc_controller.cc	View	1 chunk	+55 lines, -0 lines	0 comments	Download
D	content/shell/renderer/gc_extension.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	content/shell/renderer/gc_extension.cc	View	1 chunk	+0 lines, -29 lines	0 comments	Download
M	content/shell/renderer/shell_render_process_observer.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/shell/renderer/webkit_test_runner.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/139413003/1

6 years, 11 months ago (2014-01-15 18:50:32 UTC) #3

Message was sent while issue was closed.

Change committed as 245258

Expand Messages | Collapse Messages