Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394063004: Use common.dart to re-export commonly used entities. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use common.dart to re-export commonly used entities. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/1414d9b27e6e5b775bccbd90d914b030ee41fec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -706 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/common.dart View 1 chunk +15 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/tasks.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/work.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 2 chunks +1 line, -8 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 3 chunks +11 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/scalar_replacement.dart View 3 chunks +3 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 6 chunks +4 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 2 chunks +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +3 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 3 chunks +1 line, -10 lines 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/info/send_info.dart View 1 chunk +17 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +12 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +18 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +1 line, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 3 chunks +21 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 2 chunks +37 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +13 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +12 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +37 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 chunk +12 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 2 chunks +32 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 3 chunks +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/secret_tree_element.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 chunk +4 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/tree/tree.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 3 chunks +1 line, -9 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/call_structure.dart View 1 chunk +1 line, -13 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/side_effects.dart View 1 chunk +1 line, -23 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +1 line, -6 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_source_information_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in src/common.dart
5 years, 2 months ago (2015-10-09 13:02:31 UTC) #2
sigurdm
LGTM
5 years, 2 months ago (2015-10-12 06:38:45 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-12 07:34:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1414d9b27e6e5b775bccbd90d914b030ee41fec0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698