Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1394023005: Make RegExp use ToLength on lastIndex when flag is turned on (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make RegExp use ToLength on lastIndex when flag is turned on In the ES2015 spec, RegExp uses ToLength, not ToInteger, on lastIndex to coerce it to an integer. This patch switches to ToLength when the --harmony-tolength flag is on, and adds some tests to verify the new behavior. BUG=v8:4244 LOG=Y R=adamk Committed: https://crrev.com/5c1ef6ac823e2a57805d3eb8126f796dfe479aed Cr-Commit-Position: refs/heads/master@{#31306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M src/js/macros.py View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/regexp.js View 2 chunks +6 lines, -6 lines 0 comments Download
A test/mjsunit/harmony/regexp-tolength.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dan Ehrenberg
5 years, 2 months ago (2015-10-15 13:03:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394023005/1
5 years, 2 months ago (2015-10-15 13:03:45 UTC) #3
adamk
lgtm
5 years, 2 months ago (2015-10-15 13:09:10 UTC) #4
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-15 13:31:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-15 13:52:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394023005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394023005/1
5 years, 2 months ago (2015-10-15 14:05:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 14:10:41 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 14:10:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c1ef6ac823e2a57805d3eb8126f796dfe479aed
Cr-Commit-Position: refs/heads/master@{#31306}

Powered by Google App Engine
This is Rietveld 408576698