Issue 1394023004: allow computeErrors to work on non-.dart files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1394023004: allow computeErrors to work on non-.dart files (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, Leaf, vsm

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

allow computeErrors to work on non-.dart files This is similar to the change we made recently to resolveCompilationUnit2. If someone programmatically uses the API to request resolution errors, treat it as a Dart file. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/0544735a603fbb2131210b49f41da1ccfdfbf7fa

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/context/context.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

(this was caught again by that ".lib" file in the language tests.)

5 years, 2 months ago (2015-10-13 17:12:37 UTC) #2

Jennifer Messerly

5 years, 2 months ago (2015-10-13 18:16:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0544735a603fbb2131210b49f41da1ccfdfbf7fa (presubmit successful).