Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394003008: dart2js cps_ir: Unary operator improvements (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 2 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps_ir: Unary operator improvements ~ and - are reduced to BuiltinOperators. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/14dcffa1242d9198e90077049f69e25b7800330e

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -9 lines) Patch
M pkg/compiler/lib/src/cps_ir/builtin_operator.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 7 chunks +71 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
5 years, 2 months ago (2015-10-14 22:16:34 UTC) #2
asgerf
LGTM https://chromiumcodereview.appspot.com/1394003008/diff/1/pkg/compiler/lib/src/cps_ir/builtin_operator.dart File pkg/compiler/lib/src/cps_ir/builtin_operator.dart (right): https://chromiumcodereview.appspot.com/1394003008/diff/1/pkg/compiler/lib/src/cps_ir/builtin_operator.dart#newcode58 pkg/compiler/lib/src/cps_ir/builtin_operator.dart:58: /// "///" without a comment
5 years, 2 months ago (2015-10-15 08:58:22 UTC) #3
sra1
Committed patchset #2 (id:20001) manually as 14dcffa1242d9198e90077049f69e25b7800330e (presubmit successful).
5 years, 2 months ago (2015-10-15 19:00:27 UTC) #4
sra1
5 years, 2 months ago (2015-10-15 22:20:12 UTC) #5
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1394003008/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/cps_ir/builtin_operator.dart (right):

https://chromiumcodereview.appspot.com/1394003008/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/cps_ir/builtin_operator.dart:58: ///
On 2015/10/15 08:58:22, asgerf wrote:
> "///" without a comment

Done.

Powered by Google App Engine
This is Rietveld 408576698