Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 1394003005: AutofillPreferences: Modify UI only when it's available. (Closed)

Created:
5 years, 2 months ago by please use gerrit instead
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AutofillPreferences: Modify UI only when it's available. If an autofill profile changes when AutofillPreferences fragment is alive, but its view has been destroyed, then AutofillPreferences crashes as it tries to update the destroyed view. The fix is to start observing profile changes in onActivityCreated and stop in onDestroyView. http://developer.android.com/reference/android/app/Fragment.html#Lifecycle BUG=539962 Committed: https://crrev.com/7a320d9e42ea2648c07fd7770b157332f15af324 Cr-Commit-Position: refs/heads/master@{#353942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java View 2 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
please use gerrit instead
Aurimas, PTAL as the person probably most familiar with this code. Maria, OWNERS PTAL.
5 years, 2 months ago (2015-10-13 22:01:47 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 2 months ago (2015-10-13 22:05:38 UTC) #3
Maria
lgtm
5 years, 2 months ago (2015-10-14 01:33:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394003005/1
5 years, 2 months ago (2015-10-14 01:35:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 02:15:24 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:16:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a320d9e42ea2648c07fd7770b157332f15af324
Cr-Commit-Position: refs/heads/master@{#353942}

Powered by Google App Engine
This is Rietveld 408576698