Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1394003004: Add flag to force complex text for tests (Closed)

Created:
5 years, 2 months ago by eae
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jam, jbroman, jchaffraix+rendering, jochen+watch_chromium.org, Justin Novosad, leviw+renderwatch, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to force complex text for tests Add --always-use-complex-text flag to content_shell to force the use of the complex text path for layout tests. Thus allowing us to selectively enabled it on a per directory basis for layout tests, instead of having to rebaseline every single test at once. This is a temporary flag that will be removed once AlwaysUseComplexText runtime enabled feature has been enabled. BUG=404597 R=mkwst@chromium.org, drott@chromium.org Committed: https://crrev.com/81407eee8b5049cd7accf436293a8a003ddd2b65 Cr-Commit-Position: refs/heads/master@{#353528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/common/shell_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_process_observer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LayoutTestSupport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutTestSupport.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebKit.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
eae
5 years, 2 months ago (2015-10-12 11:18:48 UTC) #2
drott
LGTM for WebKit/*
5 years, 2 months ago (2015-10-12 11:24:36 UTC) #3
eae
Mike: please review the content/ changes Dominik: please review webkit/ changes
5 years, 2 months ago (2015-10-12 11:25:09 UTC) #4
Mike West
//content/shell LGTM.
5 years, 2 months ago (2015-10-12 11:43:41 UTC) #5
eae
Thanks!
5 years, 2 months ago (2015-10-12 11:45:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394003004/1
5 years, 2 months ago (2015-10-12 11:46:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/80639)
5 years, 2 months ago (2015-10-12 14:09:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394003004/1
5 years, 2 months ago (2015-10-12 14:38:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394003004/1
5 years, 2 months ago (2015-10-12 15:04:14 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 16:12:44 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 16:13:30 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81407eee8b5049cd7accf436293a8a003ddd2b65
Cr-Commit-Position: refs/heads/master@{#353528}

Powered by Google App Engine
This is Rietveld 408576698