Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: runtime/vm/debugger_api_impl.cc

Issue 13940008: Add library id, location info to breakpointResolved event (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | tests/standalone/debugger/debug_lib.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl.cc
===================================================================
--- runtime/vm/debugger_api_impl.cc (revision 21569)
+++ runtime/vm/debugger_api_impl.cc (working copy)
@@ -135,8 +135,15 @@
}
SourceBreakpoint* bpt = event->breakpoint;
ASSERT(bpt != NULL);
- Dart_Handle url = Api::NewHandle(isolate, bpt->SourceUrl());
- (*bp_resolved_handler)(isolate_id, bpt->id(), url, bpt->LineNumber());
+ Dart_CodeLocation location;
+ Library& library = Library::Handle(isolate);
+ Script& script = Script::Handle(isolate);
+ intptr_t token_pos;
+ bpt->GetCodeLocation(&library, &script, &token_pos);
+ location.script_url = Api::NewHandle(isolate, script.url());
+ location.library_id = library.index();
+ location.token_pos = token_pos;
+ (*bp_resolved_handler)(isolate_id, bpt->id(), location);
} else if (event->type == Debugger::kExceptionThrown) {
if (exc_thrown_handler == NULL) {
return;
« no previous file with comments | « runtime/vm/debugger.cc ('k') | tests/standalone/debugger/debug_lib.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698