apps/app_launcher.h - Issue 13940006: Remove --show-app-list-shortcut flag and implement new app launcher enable logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/app_launcher.h

Issue 13940006: Remove --show-app-list-shortcut flag and implement new app launcher enable logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove rest of start menu code Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/app_launcher.h

diff --git a/apps/app_launcher.h b/apps/app_launcher.h

index d3156a1cacbba6e1f46fedbd7252c9b4a56e671c..0ccc1bfd5d6a981a34347994cdf3ebec68965910 100644

--- a/apps/app_launcher.h

+++ b/apps/app_launcher.h

@@ -13,6 +13,11 @@ namespace apps {

// boolean flag is passed, which is true if the app launcher is enabled.

typedef base::Callback<void(bool)> OnAppLauncherEnabledCompleted;

+// TODO(calamity): Remove all the "uncertain" apis because windows app launcher

+// enabled is now just a single pref that we can check synchronously and with

+// confidence. This includes changing GetIsAppLauncherEnabled to a synchronous

+// API.

// A synchronous check to determine if the app launcher is enabled. If the

// registry needs to be determined to find an accurate answer, this function

// will NOT do so; instead if will default to false (the app launcher is not

« no previous file with comments | « no previous file | apps/app_launcher.cc » ('j') | chrome/browser/ui/views/app_list/app_list_controller_win.cc » ('J')