Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 13940003: Move context retrieval method around. Use delegation for implementation. (Closed)

Created:
7 years, 8 months ago by Sven Panne
Modified:
7 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Move context retrieval method around. Use delegation for implementation. This is a refactoring of https://code.google.com/p/v8/source/detail?r=14146. Committed: http://code.google.com/p/v8/source/detail?r=14171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M include/v8.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/api.cc View 2 chunks +10 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 8 months ago (2013-04-09 07:31:24 UTC) #1
Yang
On 2013/04/09 07:31:24, Sven Panne wrote: lgtm.
7 years, 8 months ago (2013-04-09 07:32:57 UTC) #2
Sven Panne
7 years, 8 months ago (2013-04-09 07:34:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698