Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/crash_keys.cc

Issue 1393953003: Make chrome/common pass "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/crash_keys.cc
diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc
index 3cd3cd42217b71270afb25e7880163e4a03a9b6e..8b2aabff803efc284a664feacfce1ffd25e74214 100644
--- a/chrome/common/crash_keys.cc
+++ b/chrome/common/crash_keys.cc
@@ -16,10 +16,12 @@
#include "content/public/common/content_switches.h"
#include "ipc/ipc_switches.h"
+// Breakpad dependencies exist only on Windows and Mac desktop. Exclude them
+// from "gn check" to avoid failures on Linux (it doesn't understand ifdefs).
#if defined(OS_MACOSX)
-#include "breakpad/src/common/simple_string_dictionary.h"
+#include "breakpad/src/common/simple_string_dictionary.h" // nogncheck
#elif defined(OS_WIN)
-#include "breakpad/src/client/windows/common/ipc_protocol.h"
+#include "breakpad/src/client/windows/common/ipc_protocol.h" // nogncheck
#elif defined(OS_CHROMEOS)
#include "chrome/common/chrome_switches.h"
#include "gpu/command_buffer/service/gpu_switches.h"
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698