Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 139393002: Removed apiutils.h and related cleanup. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Removed apiutils.h and related cleanup. ExtensionConfiguration is just a simple container for extension names (in a perfect world we would use vector<string> and range-based for loops), and HandleScopeData was in the totally wrong place. Some additional cleanup on the way, e.g. using the null pattern behind our external API. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18632

Patch Set 1 #

Patch Set 2 : Dummy for fixing codereview issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -124 lines) Patch
M include/v8.h View 3 chunks +23 lines, -27 lines 0 comments Download
M src/api.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/api.cc View 5 chunks +8 lines, -8 lines 0 comments Download
D src/apiutils.h View 1 chunk +0 lines, -49 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/handles.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/handles.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/handles-inl.h View 7 chunks +6 lines, -13 lines 0 comments Download
M src/isolate.h View 3 chunks +3 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-15 13:59:19 UTC) #1
dcarney
lgtm
6 years, 11 months ago (2014-01-15 15:04:52 UTC) #2
Sven Panne
6 years, 11 months ago (2014-01-16 08:17:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698