Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1393903003: Fix gcc 4.9.2 sign-compare error. (Closed)

Created:
5 years, 2 months ago by akos.palfi.imgtec
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gcc 4.9.2 sign-compare error. BUG= Committed: https://crrev.com/29ba2e04fd278bdef5ae7cb7099a5dafc8c65444 Cr-Commit-Position: refs/heads/master@{#31186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/spaces.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
paul.l...
l-g-t-m, but this needs v8 team approval, can one of you PTAL?
5 years, 2 months ago (2015-10-08 16:35:46 UTC) #2
Michael Achenbach
lgtm
5 years, 2 months ago (2015-10-08 16:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393903003/1
5 years, 2 months ago (2015-10-08 16:42:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6492)
5 years, 2 months ago (2015-10-08 16:44:01 UTC) #8
Michael Achenbach
+ hannes for owners review.
5 years, 2 months ago (2015-10-08 17:15:12 UTC) #10
Michael Lippautz
lgtm Hannes is OOO
5 years, 2 months ago (2015-10-08 19:00:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393903003/1
5 years, 2 months ago (2015-10-08 19:32:59 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 19:34:06 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 19:34:30 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/29ba2e04fd278bdef5ae7cb7099a5dafc8c65444
Cr-Commit-Position: refs/heads/master@{#31186}

Powered by Google App Engine
This is Rietveld 408576698