runtime/bin/vmstats/bargraph.dart - Issue 13939003: Fixed stack trace for isolates without any Dart frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmstats/bargraph.dart

Issue 13939003: Fixed stack trace for isolates without any Dart frames. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed divide-by-zero error in bargraph.dart Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/vmstats/bargraph.dart

===================================================================

--- runtime/bin/vmstats/bargraph.dart (revision 21220)

+++ runtime/bin/vmstats/bargraph.dart (working copy)

@@ -188,7 +188,7 @@

* Returns the maximum total from all the samples.

int get maxTotal {

- var max = 0;

+ var max = 1; // Must be non-zero.

_samples.forEach((Sample s) => max = (s.total() > max ? s.total() : max));

return max;

}

« no previous file with comments | « no previous file | runtime/bin/vmstats/isolate_list.dart » ('j') | runtime/vm/isolate.cc » ('J')