WebRTC: Refactor builder configs to reduce duplication.

WebRTC: Refactor builder configs to reduce duplication.

This removes a lot of duplication and makes it easier to
get an overview of what builders are configured for these masters.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297163

[kjellander_chromium, 2015-10-15 12:00:11]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 12:00:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393893006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393893006/1

[commit-bot: I haz the power, 2015-10-15 12:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 12:03:37]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2015-10-15 12:08:39]

kjellander@chromium.org changed reviewers:
+ nodir@chromium.org

[kjellander_chromium, 2015-10-15 12:08:40]

As promised, and sooner than I expected!
The category setting adds a bit of duplication, but I think that's fine
considering the alternatives would make the code less readable.

https://codereview.chromium.org/1393893006/diff/1/masters/master.chromium.web...
File masters/master.chromium.webrtc.fyi/master_builders_cfg.py (right):

https://codereview.chromium.org/1393893006/diff/1/masters/master.chromium.web...
masters/master.chromium.webrtc.fyi/master_builders_cfg.py:124: if
'slavebuilddir' in spec:
From reading the code it looks like the behavior is different when
'slavebuilddir' is missing and when it exists but has a value of None. Because
of that I didn't want to risk changing behavior, which led to this solution.

Previously all builders had it set, but I know from previous experience that if
it's not set, the builder will get a slave build dir named similarly to the
builder name, which is fine with ours, since there aren't that many different
builders sharing the same machines.

[nodir, 2015-10-15 22:27:48]

lgtm % optional suggestion

https://codereview.chromium.org/1393893006/diff/1/masters/master.chromium.web...
File masters/master.chromium.webrtc.fyi/master_builders_cfg.py (right):

https://codereview.chromium.org/1393893006/diff/1/masters/master.chromium.web...
masters/master.chromium.webrtc.fyi/master_builders_cfg.py:24: 'Android GN
(dbg)',
sort?

[kjellander_chromium, 2015-10-16 10:09:08]

https://codereview.chromium.org/1393893006/diff/1/masters/master.chromium.web...
File masters/master.chromium.webrtc.fyi/master_builders_cfg.py (right):

https://codereview.chromium.org/1393893006/diff/1/masters/master.chromium.web...
masters/master.chromium.webrtc.fyi/master_builders_cfg.py:24: 'Android GN
(dbg)',
On 2015/10/15 22:27:48, nodir wrote:
> sort?

Oh, right. This is the order they're displayed in the waterfall, but I realize
now that only matters for the spec listing below, so I've sorted this now.

[kjellander_chromium, 2015-10-16 10:09:14]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2015-10-16 10:09:14]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/1393893006/#ps20001
(title: "Sorted alphabetically")

[commit-bot: I haz the power, 2015-10-16 10:09:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393893006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393893006/20001

[commit-bot: I haz the power, 2015-10-16 10:12:48]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297163