Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: testing/embedder_test.h

Issue 1393833006: Merge to XFA: Allow compiling PDFium without V8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebase, fix build, stray include. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/samples.gyp ('k') | testing/embedder_test.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/embedder_test.h
diff --git a/testing/embedder_test.h b/testing/embedder_test.h
index f6842d23c3233701f51d94c4887303ebf0b7709f..fb3ea428f16e1e2cc0ac4a8f2a973597f68bab60 100644
--- a/testing/embedder_test.h
+++ b/testing/embedder_test.h
@@ -14,7 +14,10 @@
#include "../public/fpdfview.h"
#include "../third_party/base/nonstd_unique_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
+
+#ifdef PDF_ENABLE_V8
#include "v8/include/v8.h"
+#endif // PDF_ENABLE_v8
class TestLoader;
@@ -61,8 +64,12 @@ class EmbedderTest : public ::testing::Test,
void SetUp() override;
void TearDown() override;
+#ifdef PDF_ENABLE_V8
// Call before SetUp to pass shared isolate, otherwise PDFium creates one.
- void SetExternalIsolate(v8::Isolate* isolate) { external_isolate_ = isolate; }
+ void SetExternalIsolate(void* isolate) {
+ external_isolate_ = static_cast<v8::Isolate*>(isolate);
+ }
+#endif // PDF_ENABLE_V8
void SetDelegate(Delegate* delegate) {
delegate_ = delegate ? delegate : default_delegate_.get();
@@ -105,10 +112,12 @@ class EmbedderTest : public ::testing::Test,
FX_DOWNLOADHINTS hints_;
FPDF_FILEACCESS file_access_;
FX_FILEAVAIL file_avail_;
+#ifdef PDF_ENABLE_V8
v8::Platform* platform_;
v8::StartupData natives_;
v8::StartupData snapshot_;
- v8::Isolate* external_isolate_;
+#endif // PDF_ENABLE_V8
+ void* external_isolate_;
TestLoader* loader_;
size_t file_length_;
char* file_contents_;
« no previous file with comments | « samples/samples.gyp ('k') | testing/embedder_test.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698