Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1393833003: SkPath::fFirstDirection: seq-cst -> relaxed (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPath::fFirstDirection: seq-cst -> relaxed We landed this originally with lazily-correct sequentially-consistent memory order. It turns out that's regressed performance, we think particularly when recording paths. We also think there's no need for anything but relaxed memory order here. We should see this chart go down if all goes well: https://perf.skia.org/#4329 There are also Chrome performance charts to watch in the linked bug. BUG=chromium:537700 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/bf90520f63415f539cd5792a18efbd79cb86be0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M include/core/SkPath.h View 1 chunk +6 lines, -7 lines 0 comments Download
M include/private/SkAtomics.h View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393833003/1
5 years, 2 months ago (2015-10-07 17:29:55 UTC) #2
mtklein_C
5 years, 2 months ago (2015-10-07 17:36:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 17:42:00 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393833003/1
5 years, 2 months ago (2015-10-07 17:42:34 UTC) #8
herb_g
lgtm
5 years, 2 months ago (2015-10-07 18:39:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393833003/1
5 years, 2 months ago (2015-10-07 18:39:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3084)
5 years, 2 months ago (2015-10-07 18:41:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393833003/1
5 years, 2 months ago (2015-10-07 19:00:48 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 19:46:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bf90520f63415f539cd5792a18efbd79cb86be0a

Powered by Google App Engine
This is Rietveld 408576698