Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1393833002: [heap] Reland prepare code for smaller large object allocation limit than max allocatable memory. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Lippautz, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland prepare code for smaller large object allocation limit than max allocatable memory. BUG= Committed: https://crrev.com/5d125f218ae91bf447c833cc54dd29946be127ab Cr-Commit-Position: refs/heads/master@{#31136}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -82 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 6 chunks +12 lines, -9 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.h View 2 chunks +53 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 4 chunks +10 lines, -35 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Lippautz
lgtm
5 years, 2 months ago (2015-10-07 08:34:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393833002/20001
5 years, 2 months ago (2015-10-07 08:34:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6422)
5 years, 2 months ago (2015-10-07 08:38:29 UTC) #6
Jarin
lgtm (rubber-stamp)
5 years, 2 months ago (2015-10-07 09:10:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393833002/20001
5 years, 2 months ago (2015-10-07 09:10:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 09:13:59 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 09:14:25 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5d125f218ae91bf447c833cc54dd29946be127ab
Cr-Commit-Position: refs/heads/master@{#31136}

Powered by Google App Engine
This is Rietveld 408576698