Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 139383006: Pass allow_delayed_resize in CompositorFrameMetadata (Closed)

Created:
6 years, 11 months ago by Xianzhu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Pass allow_delayed_resize in CompositorFrameMetadata Delayed resize on top-control show/hide may cause inconsistency between the compositor and blink about the position of bottom- fixed-position elements. If touch occurs during the inconsistency, the touch may be sent to the wrong element. Now pass allow_delayed_resize in CompositorFrameMetadata. It's false if there is any bottom-fixed-position element in the page. The Java side FullScreenManager won't delay resize if |!allow_delayed_resize|. BUG=334779

Patch Set 1 #

Patch Set 2 : Pass allow_delayed_resize in CompositorFrameMetadata #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -53 lines) Patch
M cc/output/compositor_frame_metadata.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M cc/output/compositor_frame_metadata.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.h View 1 5 chunks +9 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 4 chunks +14 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 1 chunk +1 line, -9 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 chunks +17 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +2 lines, -13 lines 0 comments Download
M content/common/cc_messages.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Xianzhu
Patch Set 2 simpifies Patch Set 1 which was an experiment of passing end-of-fling in ...
6 years, 11 months ago (2014-01-22 00:05:17 UTC) #1
aelias_OOO_until_Jul13
Hmm, it doesn't feel right for the browser compositor to have to know whether a ...
6 years, 11 months ago (2014-01-22 03:57:16 UTC) #2
Xianzhu
On 2014/01/22 03:57:16, aelias wrote: > Hmm, it doesn't feel right for the browser compositor ...
6 years, 11 months ago (2014-01-22 20:46:01 UTC) #3
Xianzhu
6 years, 11 months ago (2014-01-22 22:44:18 UTC) #4
On 2014/01/22 20:46:01, Xianzhu wrote:
> Perhaps we can let the compositor know blink's viewport size
> and adjust the position of the event if it hit any bottom fixed pos element
> (compositor's position).

Just noticed the above won't work. For example, a bottom fixed pos element E, in
blink its position is EP and in compositor its position is EP' (where the user
sees E). We'll encounter problem when a touch event is in EP (where shows not E
but some background layer of E) but not in EP'.

Powered by Google App Engine
This is Rietveld 408576698