Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 139383002: Revert of Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
tkent, Andrey Kraynov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} (https://codereview.chromium.org/119113003/) Reason for revert: The follow-up patch was reverted. I guess it would be easier to do the copy and refactoring in one CL, so we don't end up with a copy of WebFrameImpl.* that gets stale before the refactoring is finished. Original issue's description: > Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h} > > This patch copies Source/web/WebFrameImpl.{cpp,h} into Source/web/TextFinder.{cpp,h} for decoupling WebFrameImpl and text finder. > > Another patch will complete decoupling. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164490 TBR=tkent@chromium.org,iceman@yandex-team.ru NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165120

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2975 lines) Patch
D Source/web/TextFinder.h View 1 1 chunk +0 lines, -533 lines 0 comments Download
D Source/web/TextFinder.cpp View 1 1 chunk +0 lines, -2442 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Copy WebFrameImpl.{cpp,h} to TextFinder.{cpp,h}
6 years, 11 months ago (2014-01-15 13:13:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/139383002/80001
6 years, 11 months ago (2014-01-15 13:28:55 UTC) #2
commit-bot: I haz the power
Change committed as 165120
6 years, 11 months ago (2014-01-15 13:46:14 UTC) #3
tkent
6 years, 11 months ago (2014-01-16 01:43:45 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698