Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Unified Diff: content/browser/service_worker/service_worker_script_cache_map.cc

Issue 1393783002: ServiceWorker: Schedule DeleteAndStartOver when failing to store resource ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simplify the patch Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_script_cache_map.cc
diff --git a/content/browser/service_worker/service_worker_script_cache_map.cc b/content/browser/service_worker/service_worker_script_cache_map.cc
index 16931391663b12a1d2749258769979e6d8df931c..3f8146ffe6b31fcf9b5ba06673a92131d712d2d8 100644
--- a/content/browser/service_worker/service_worker_script_cache_map.cc
+++ b/content/browser/service_worker/service_worker_script_cache_map.cc
@@ -48,7 +48,7 @@ void ServiceWorkerScriptCacheMap::NotifyStartedCaching(
return; // Our storage has been wiped via DeleteAndStartOver.
resource_map_[url] =
ServiceWorkerDatabase::ResourceRecord(resource_id, url, -1);
- context_->storage()->StoreUncommittedResponseId(resource_id);
+ context_->storage()->StoreUncommittedResourceId(resource_id);
falken 2015/10/15 05:03:40 Yeah, this naming has been a bit inconsistent sinc
}
void ServiceWorkerScriptCacheMap::NotifyFinishedCaching(
@@ -63,7 +63,7 @@ void ServiceWorkerScriptCacheMap::NotifyFinishedCaching(
if (!context_)
return; // Our storage has been wiped via DeleteAndStartOver.
if (!status.is_success()) {
- context_->storage()->DoomUncommittedResponse(LookupResourceId(url));
+ context_->storage()->DoomUncommittedResource(LookupResourceId(url));
resource_map_.erase(url);
if (owner_->script_url() == url) {
main_script_status_ = status;

Powered by Google App Engine
This is Rietveld 408576698