Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1393733002: Fix GN compile of gn_all (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, agrieve, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN compile of gn_all BUG=1392773002 Committed: https://crrev.com/ba3c248b4aad1dfade254ee1bb2f967a8c73e39f Cr-Commit-Position: refs/heads/master@{#353851}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
pkotwicz
agrieve@ PTAL
5 years, 2 months ago (2015-10-07 02:43:55 UTC) #2
agrieve
On 2015/10/07 02:43:55, pkotwicz wrote: > agrieve@ PTAL lgtm
5 years, 2 months ago (2015-10-07 03:14:40 UTC) #3
pkotwicz
dpranke@ for OWNERS
5 years, 2 months ago (2015-10-07 14:33:37 UTC) #5
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-07 18:08:37 UTC) #6
pkotwicz
sky@ for rubberstamp of content/test
5 years, 2 months ago (2015-10-07 18:18:06 UTC) #9
pkotwicz
sky@ for rubberstamp of content/test
5 years, 2 months ago (2015-10-07 18:18:16 UTC) #10
pkotwicz
Scott, Ping!
5 years, 2 months ago (2015-10-13 17:56:46 UTC) #12
sky
LGTM
5 years, 2 months ago (2015-10-13 19:52:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393733002/40001
5 years, 2 months ago (2015-10-13 20:20:16 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-13 21:12:36 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 21:14:01 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ba3c248b4aad1dfade254ee1bb2f967a8c73e39f
Cr-Commit-Position: refs/heads/master@{#353851}

Powered by Google App Engine
This is Rietveld 408576698