Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: src/generator.js

Issue 1393713006: Don't compile functions in a context the caller doesn't have access to (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/d8.cc ('k') | src/runtime/runtime-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 6
7 "use strict"; 7 "use strict";
8 8
9 %CheckIsBootstrapping(); 9 %CheckIsBootstrapping();
10 10
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 throw MakeTypeError(kGeneratorRunning); 73 throw MakeTypeError(kGeneratorRunning);
74 } 74 }
75 } 75 }
76 76
77 77
78 function GeneratorFunctionConstructor(arg1) { // length == 1 78 function GeneratorFunctionConstructor(arg1) { // length == 1
79 var source = NewFunctionString(arguments, 'function*'); 79 var source = NewFunctionString(arguments, 'function*');
80 var global_proxy = %GlobalProxy(GeneratorFunctionConstructor); 80 var global_proxy = %GlobalProxy(GeneratorFunctionConstructor);
81 // Compile the string in the constructor and not a helper so that errors 81 // Compile the string in the constructor and not a helper so that errors
82 // appear to come from here. 82 // appear to come from here.
83 var f = %_CallFunction(global_proxy, %CompileString(source, true)); 83 var f = %CompileString(source, true);
84 if (!IS_FUNCTION(f)) return f;
85 f = %_CallFunction(global_proxy, f);
84 %FunctionMarkNameShouldPrintAsAnonymous(f); 86 %FunctionMarkNameShouldPrintAsAnonymous(f);
85 return f; 87 return f;
86 } 88 }
87 89
88 // ---------------------------------------------------------------------------- 90 // ----------------------------------------------------------------------------
89 91
90 // Both Runtime_GeneratorNext and Runtime_GeneratorThrow are supported by 92 // Both Runtime_GeneratorNext and Runtime_GeneratorThrow are supported by
91 // neither Crankshaft nor TurboFan, disable optimization of wrappers here. 93 // neither Crankshaft nor TurboFan, disable optimization of wrappers here.
92 %NeverOptimizeFunction(GeneratorObjectNext); 94 %NeverOptimizeFunction(GeneratorObjectNext);
93 %NeverOptimizeFunction(GeneratorObjectThrow); 95 %NeverOptimizeFunction(GeneratorObjectThrow);
(...skipping 11 matching lines...) Expand all
105 toStringTagSymbol, "Generator", DONT_ENUM | READ_ONLY); 107 toStringTagSymbol, "Generator", DONT_ENUM | READ_ONLY);
106 %InternalSetPrototype(GeneratorFunctionPrototype, GlobalFunction.prototype); 108 %InternalSetPrototype(GeneratorFunctionPrototype, GlobalFunction.prototype);
107 %AddNamedProperty(GeneratorFunctionPrototype, 109 %AddNamedProperty(GeneratorFunctionPrototype,
108 toStringTagSymbol, "GeneratorFunction", DONT_ENUM | READ_ONLY); 110 toStringTagSymbol, "GeneratorFunction", DONT_ENUM | READ_ONLY);
109 %AddNamedProperty(GeneratorFunctionPrototype, "constructor", 111 %AddNamedProperty(GeneratorFunctionPrototype, "constructor",
110 GeneratorFunction, DONT_ENUM | READ_ONLY); 112 GeneratorFunction, DONT_ENUM | READ_ONLY);
111 %InternalSetPrototype(GeneratorFunction, GlobalFunction); 113 %InternalSetPrototype(GeneratorFunction, GlobalFunction);
112 %SetCode(GeneratorFunction, GeneratorFunctionConstructor); 114 %SetCode(GeneratorFunction, GeneratorFunctionConstructor);
113 115
114 }) 116 })
OLDNEW
« no previous file with comments | « src/d8.cc ('k') | src/runtime/runtime-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698