Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: components/cronet/tools/generate_javadoc.py

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix missing test annotation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/tools/generate_javadoc.py
diff --git a/components/cronet/tools/generate_javadoc.py b/components/cronet/tools/generate_javadoc.py
index f21ceb3d014409a19fc79ae8192b6adf9dc9331e..4c13c03f48bc10c192d3852af3a3c207ff975c2e 100755
--- a/components/cronet/tools/generate_javadoc.py
+++ b/components/cronet/tools/generate_javadoc.py
@@ -35,11 +35,13 @@ def GenerateJavadoc(options):
output_dir = os.path.abspath(os.path.join(options.output_dir, 'javadoc'))
working_dir = os.path.join(options.input_dir, 'android/api')
overview_file = os.path.abspath(options.overview_file)
+ lib_java_dir = os.path.abspath(options.lib_java_dir)
build_utils.DeleteDirectory(output_dir)
build_utils.MakeDirectory(output_dir)
javadoc_cmd = ['ant', '-Dsource.dir=src', '-Ddoc.dir=' + output_dir,
- '-Doverview=' + overview_file, 'doc']
+ '-Dlib.java.dir=' + lib_java_dir, '-Doverview=' + overview_file,
+ 'doc']
stdout = build_utils.CheckOutput(javadoc_cmd, cwd=working_dir)
if " error: " in stdout or "warning" in stdout:
build_utils.DeleteDirectory(output_dir)
@@ -53,6 +55,7 @@ def main():
parser.add_option('--input-dir', help='Root of cronet source')
parser.add_option('--overview-file', help='Path of the overview page')
parser.add_option('--readme-file', help='Path of the README.md')
+ parser.add_option('--lib-java-dir', help='Directory containing java libs')
options, _ = parser.parse_args()
« components/cronet/android/url_request_error.h ('K') | « components/cronet/cronet_static.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698