components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java - Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix missing test annotation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java » ('j') | components/cronet/android/url_request_error.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

index 3c85b783ef166985dd55fac591e7cb255a9fa70b..8acd5bec8590fdc5eb5be571949eb1b33bc32c65 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

@@ -154,7 +154,7 @@ public class BidirectionalStreamTest extends CronetTestBase {

assertTrue(stream.isDone());

assertEquals("Exception in BidirectionalStream: net::ERR_DISALLOWED_URL_SCHEME",

callback.mError.getMessage());

- assertEquals(-301, callback.mError.netError());

+ assertEquals(-301, callback.mError.getCronetInternalErrorCode());

}

@SmallTest