components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java - Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix missing test annotation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_adapter.cc ('k') | components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java » ('j') | components/cronet/android/url_request_error.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

index 53fdea1ce54a37000f1979b000bd078a97769a3d..91255732d335999c3a1dd128efd36af9b2cdd80b 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

@@ -428,12 +428,13 @@ class CronetBidirectionalStream extends BidirectionalStream {

@SuppressWarnings("unused")

@CalledByNative

- private void onError(final int nativeError, final String errorString, long receivedBytesCount) {

+ private void onError(

+ int errorCode, int nativeError, String errorString, long receivedBytesCount) {

if (mResponseInfo != null) {

mResponseInfo.setReceivedBytesCount(receivedBytesCount);

}

failWithException(new CronetException(

- "Exception in BidirectionalStream: " + errorString, nativeError));

+ "Exception in BidirectionalStream: " + errorString, errorCode, nativeError));

}

/**