components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java - Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix missing test annotation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/api/build.xml ('k') | components/cronet/android/api/src/org/chromium/net/CronetException.java » ('j') | components/cronet/android/url_request_error.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

diff --git a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

index 091befc83ad6c1e03b6d2af2f383a273920c7e43..5b6d04bfc427ba4052019ed18cb7c70cbb54004f 100644

--- a/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

+++ b/components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java

@@ -261,8 +261,8 @@ public abstract class BidirectionalStream {

/**

* Invoked if the stream failed for any reason after {@link BidirectionalStream#start}.

* <a href="https://tools.ietf.org/html/rfc7540#section-7">HTTP/2 error codes</a> are

- * mapped to {@link CronetException#netError} codes. Once invoked, no further

- * {@link BidirectionalStream.Callback} methods will be invoked.

+ * mapped to {@link UrlRequestException#getCronetInternalErrorCode} codes. Once invoked,

+ * no further {@link BidirectionalStream.Callback} methods will be invoked.

* @param stream the stream which has failed

* @param info the response information. May be {@code null} if no response was