Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java
index 5c46dbf52dc8a56747eb2576bf9dea3f43ffcbcf..745536cc51bfeaf27a1d324eab5217278fa864d1 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java
@@ -8,6 +8,7 @@ import android.os.ConditionVariable;
import static junit.framework.Assert.assertEquals;
import static junit.framework.Assert.assertFalse;
+import static junit.framework.Assert.assertNotNull;
import static junit.framework.Assert.assertNull;
import static junit.framework.Assert.assertTrue;
@@ -218,6 +219,15 @@ class TestUrlRequestListener extends UrlRequestListener {
// Should happen at most once for a single request.
assertFalse(mOnErrorCalled);
assertNull(mError);
+ if (mFailureType == FailureType.THROW_SYNC) {
+ assertEquals(UrlRequestError.LISTENER_THREW, error.getErrorCode());
+ assertEquals(0, error.netError());
+ assertEquals("UrlRequestListener method has thrown an exception", error.getMessage());
+ assertNotNull(error.getCause());
+ assertTrue(error.getCause() instanceof IllegalStateException);
+ assertEquals("Listener Exception.", error.getCause().getMessage());
+ assertFalse(error.immediatelyRetryable());
+ }
mOnErrorCalled = true;
mError = error;

Powered by Google App Engine
This is Rietveld 408576698