Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1393713004: Do not run mjsunit/compare-known-objects-slow in GC-stress mode. (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not run mjsunit/compare-known-objects-slow in GC-stress mode. NOTRY=true Committed: https://crrev.com/77faf5d0f13c5ae50917495e078b0553cb750966 Cr-Commit-Position: refs/heads/master@{#31155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Igor Sheludko
PTAL
5 years, 2 months ago (2015-10-07 14:47:17 UTC) #2
Michael Achenbach
lgtm - rubberstamp - is this temporary or forever? +does it potentially affect all gc_stress ...
5 years, 2 months ago (2015-10-07 14:49:48 UTC) #3
Igor Sheludko
On 2015/10/07 14:49:48, Michael Achenbach wrote: > lgtm - rubberstamp - is this temporary or ...
5 years, 2 months ago (2015-10-07 14:54:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393713004/1
5 years, 2 months ago (2015-10-07 14:54:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 14:56:50 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 14:57:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77faf5d0f13c5ae50917495e078b0553cb750966
Cr-Commit-Position: refs/heads/master@{#31155}

Powered by Google App Engine
This is Rietveld 408576698