Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/io_thread_unittest.cc

Issue 1393713003: Remove insecure QUIC support from Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/metrics/field_trial.h" 6 #include "base/metrics/field_trial.h"
7 #include "base/test/mock_entropy_provider.h" 7 #include "base/test/mock_entropy_provider.h"
8 #include "chrome/browser/io_thread.h" 8 #include "chrome/browser/io_thread.h"
9 #include "chrome/common/chrome_switches.h" 9 #include "chrome/common/chrome_switches.h"
10 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_param s.h" 10 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_param s.h"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 } 148 }
149 149
150 TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) { 150 TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
151 field_trial_group_ = "Enabled"; 151 field_trial_group_ = "Enabled";
152 152
153 ConfigureQuicGlobals(); 153 ConfigureQuicGlobals();
154 net::HttpNetworkSession::Params default_params; 154 net::HttpNetworkSession::Params default_params;
155 net::HttpNetworkSession::Params params; 155 net::HttpNetworkSession::Params params;
156 InitializeNetworkSessionParams(&params); 156 InitializeNetworkSessionParams(&params);
157 EXPECT_TRUE(params.enable_quic); 157 EXPECT_TRUE(params.enable_quic);
158 EXPECT_FALSE(params.enable_insecure_quic);
159 EXPECT_TRUE(params.enable_quic_for_proxies); 158 EXPECT_TRUE(params.enable_quic_for_proxies);
160 EXPECT_EQ(1350u, params.quic_max_packet_length); 159 EXPECT_EQ(1350u, params.quic_max_packet_length);
161 EXPECT_EQ(1.0, params.alternative_service_probability_threshold); 160 EXPECT_EQ(1.0, params.alternative_service_probability_threshold);
162 EXPECT_EQ(default_params.quic_supported_versions, 161 EXPECT_EQ(default_params.quic_supported_versions,
163 params.quic_supported_versions); 162 params.quic_supported_versions);
164 EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options); 163 EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options);
165 EXPECT_FALSE(params.quic_always_require_handshake_confirmation); 164 EXPECT_FALSE(params.quic_always_require_handshake_confirmation);
166 EXPECT_FALSE(params.quic_disable_connection_pooling); 165 EXPECT_FALSE(params.quic_disable_connection_pooling);
167 EXPECT_EQ(0.25f, params.quic_load_server_info_timeout_srtt_multiplier); 166 EXPECT_EQ(0.25f, params.quic_load_server_info_timeout_srtt_multiplier);
168 EXPECT_FALSE(params.quic_enable_connection_racing); 167 EXPECT_FALSE(params.quic_enable_connection_racing);
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 command_line_.AppendSwitch("enable-quic"); 242 command_line_.AppendSwitch("enable-quic");
244 command_line_.AppendSwitch("enable-alternative-services"); 243 command_line_.AppendSwitch("enable-alternative-services");
245 244
246 ConfigureQuicGlobals(); 245 ConfigureQuicGlobals();
247 net::HttpNetworkSession::Params params; 246 net::HttpNetworkSession::Params params;
248 InitializeNetworkSessionParams(&params); 247 InitializeNetworkSessionParams(&params);
249 EXPECT_TRUE(params.enable_quic); 248 EXPECT_TRUE(params.enable_quic);
250 EXPECT_TRUE(params.use_alternative_services); 249 EXPECT_TRUE(params.use_alternative_services);
251 } 250 }
252 251
253 TEST_F(IOThreadTest, EnableInsecureQuicFromFieldTrialParams) {
254 field_trial_group_ = "Enabled";
255 field_trial_params_["enable_insecure_quic"] = "true";
256
257 ConfigureQuicGlobals();
258 net::HttpNetworkSession::Params params;
259 InitializeNetworkSessionParams(&params);
260 EXPECT_TRUE(params.enable_insecure_quic);
261 }
262
263 TEST_F(IOThreadTest, EnableInsecureQuicCommandLine) {
264 command_line_.AppendSwitch("enable-quic");
265 command_line_.AppendSwitch("enable-insecure-quic");
266
267 ConfigureQuicGlobals();
268 net::HttpNetworkSession::Params params;
269 InitializeNetworkSessionParams(&params);
270 EXPECT_TRUE(params.enable_insecure_quic);
271 }
272
273 TEST_F(IOThreadTest, PacketLengthFromCommandLine) { 252 TEST_F(IOThreadTest, PacketLengthFromCommandLine) {
274 command_line_.AppendSwitch("enable-quic"); 253 command_line_.AppendSwitch("enable-quic");
275 command_line_.AppendSwitchASCII("quic-max-packet-length", "1450"); 254 command_line_.AppendSwitchASCII("quic-max-packet-length", "1450");
276 255
277 ConfigureQuicGlobals(); 256 ConfigureQuicGlobals();
278 net::HttpNetworkSession::Params params; 257 net::HttpNetworkSession::Params params;
279 InitializeNetworkSessionParams(&params); 258 InitializeNetworkSessionParams(&params);
280 EXPECT_EQ(1450u, params.quic_max_packet_length); 259 EXPECT_EQ(1450u, params.quic_max_packet_length);
281 } 260 }
282 261
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 command_line_.AppendSwitch(switches::kEnableQuic); 483 command_line_.AppendSwitch(switches::kEnableQuic);
505 is_quic_allowed_by_policy_ = false; 484 is_quic_allowed_by_policy_ = false;
506 ConfigureQuicGlobals(); 485 ConfigureQuicGlobals();
507 486
508 net::HttpNetworkSession::Params params; 487 net::HttpNetworkSession::Params params;
509 InitializeNetworkSessionParams(&params); 488 InitializeNetworkSessionParams(&params);
510 EXPECT_FALSE(params.enable_quic); 489 EXPECT_FALSE(params.enable_quic);
511 } 490 }
512 491
513 } // namespace test 492 } // namespace test
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698