Really fix build after r193020.

Really fix build after r193020.

Argh. Macros are evil.

BUG=
TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193029

[dcheng, 2013-04-09 06:27:48]

Committed patchset #1 manually as r193029.

[Randy Smith (Not in Mondays), 2013-04-09 12:40:28]

I'd recommend putting a comment about this (mis-)pattern at the declaration of
FILE_PATH_LITERAL().  Most people use new constructs by copy-and-paste, and are
moderately likely to see FILE_PATH_LITERAL("something") -> FILE_PATH_LITERAL("")
as copy-and-paste (i.e. this usage is going to keep creeping back) but I think
you'll be able to slow the bleed down by warning against it at the FPL decl.

[dcheng, 2013-04-09 16:09:30]

On 2013/04/09 12:40:28, rdsmith wrote:
> I'd recommend putting a comment about this (mis-)pattern at the declaration of
> FILE_PATH_LITERAL().  Most people use new constructs by copy-and-paste, and
are
> moderately likely to see FILE_PATH_LITERAL("something") ->
FILE_PATH_LITERAL("")
> as copy-and-paste (i.e. this usage is going to keep creeping back) but I think
> you'll be able to slow the bleed down by warning against it at the FPL decl.

It's tricky, because it's not always clear when this ends up turning into a
basic_string instance, due to the implicit constructor. This is actually a check
I plan on adding to Clang at some point.