Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: net/http/http_auth_handler_basic.h

Issue 1393693002: [net/http auth] Split HttpAuthHandler creation from initialization. Base URL: https://chromium.googlesource.com/chromium/src.git@rename-auth-handler-methods
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_basic.h
diff --git a/net/http/http_auth_handler_basic.h b/net/http/http_auth_handler_basic.h
index 4f369cc3ddb7f23e629b9ee6cdf280b64927350a..af59584310e368478000576098c2d7b0fc2afef8 100644
--- a/net/http/http_auth_handler_basic.h
+++ b/net/http/http_auth_handler_basic.h
@@ -21,29 +21,32 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerBasic : public HttpAuthHandler {
Factory();
~Factory() override;
- int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
- HttpAuth::Target target,
- const GURL& origin,
- CreateReason reason,
- int digest_nonce_count,
- const BoundNetLog& net_log,
- scoped_ptr<HttpAuthHandler>* handler) override;
+ // HttpAuthHandlerFactory
+ scoped_ptr<HttpAuthHandler> CreateAuthHandlerForScheme(
+ const std::string& scheme) override;
+ scoped_ptr<HttpAuthHandler> CreateAndInitPreemptiveAuthHandler(
+ HttpAuthCache::Entry* cache_entry,
+ const HttpAuthChallengeTokenizer& tokenizer,
+ HttpAuth::Target target,
+ const BoundNetLog& net_log) override;
};
+ ~HttpAuthHandlerBasic() override {}
+
+ // HttpAuthHandler
HttpAuth::AuthorizationResult HandleAnotherChallenge(
const HttpAuthChallengeTokenizer& challenge) override;
protected:
+ // HttpAuthHandler
int Init(const HttpAuthChallengeTokenizer& challenge) override;
-
int GenerateAuthTokenImpl(const AuthCredentials* credentials,
const HttpRequestInfo& request,
const CompletionCallback& callback,
std::string* auth_token) override;
private:
- ~HttpAuthHandlerBasic() override {}
-
+ HttpAuthHandlerBasic();
int ParseChallenge(const HttpAuthChallengeTokenizer& challenge);
};
« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698