Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1393673005: Fix an issue that an invalid surface could be passed to MediaPlayerBridge (Closed)

Created:
5 years, 2 months ago by qinmin
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, asanka, posciak+watch_chromium.org, benjhayden+dwatch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Fix an issue that an invalid surface could be passed to MediaPlayerBridge When entering fullscreen, setVideoSurface() can be called before OnMediaPrepared(). It is then possible that user immediately exits fullscreen video. In that case, when onMediaPrepared() is called, the surface is already released. We need to check whether a surface is valid or not before passing it to MediaPlayer. TBR=sievers BUG=540990 Review URL: https://codereview.chromium.org/1398703003 Cr-Commit-Position: refs/heads/master@{#353219} (cherry picked from commit ddcd5f8b7c909bd437576411498008d4450239da) Throttle media decoding after excessive Android media server crashes This change adds a watch dog player to listen to android MediaServer crashes. When the number of crashes reaches a certain threshold, all media decoding using Android MediaPlayer/MediaCodec will be throttled. This will throttle both media and webaudio implementation. BUG=532745 Review URL: https://codereview.chromium.org/1372203002 Cr-Commit-Position: refs/heads/master@{#352740} (cherry picked from commit b2341d25796fe6f94fb9a2d00104f2f88ca67a7c) Committed: https://chromium.googlesource.com/chromium/src/+/83a90d3befcb37b68620d63782be6c4283cd697b

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M media/base/android/media_player_bridge.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ui/gl/android/scoped_java_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
5 years, 2 months ago (2015-10-09 17:22:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
83a90d3befcb37b68620d63782be6c4283cd697b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698