Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1393673004: Factor out the actual break checking from apply{After,Before}Break(). (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out the actual break checking from apply{After,Before}Break(). We're soon going to call this from the column balancing code. Moved inNormalFlow() to isForcedBreakAllowed(). The new function performs some additional checks to make sure it's an in-flow block level element. That assumption could safely be made from apply{After,Before}Break(), but other call sites shouldn't have to worry about such things. Removed FIXME pair for something that was already working. R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/77e28bf27545d7c9cc00a77bf81f4e5c2cbd22ed Cr-Commit-Position: refs/heads/master@{#353021}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +4 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +40 lines, -0 lines 3 comments Download

Messages

Total messages: 7 (1 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-07 19:34:20 UTC) #1
leviw_travelin_and_unemployed
https://codereview.chromium.org/1393673004/diff/1/third_party/WebKit/Source/core/layout/LayoutBox.cpp File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right): https://codereview.chromium.org/1393673004/diff/1/third_party/WebKit/Source/core/layout/LayoutBox.cpp#newcode1806 third_party/WebKit/Source/core/layout/LayoutBox.cpp:1806: bool checkPageBreaks = !checkColumnBreaks && view()->layoutState()->pageLogicalHeight(); // TODO(mstensho): Once ...
5 years, 2 months ago (2015-10-08 08:29:14 UTC) #2
leviw_travelin_and_unemployed
LGTM
5 years, 2 months ago (2015-10-08 08:29:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393673004/1
5 years, 2 months ago (2015-10-08 08:29:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 08:34:01 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 08:34:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77e28bf27545d7c9cc00a77bf81f4e5c2cbd22ed
Cr-Commit-Position: refs/heads/master@{#353021}

Powered by Google App Engine
This is Rietveld 408576698