Factor out the actual break checking from apply{After,Before}Break().

Factor out the actual break checking from apply{After,Before}Break().

We're soon going to call this from the column balancing code.

Moved inNormalFlow() to isForcedBreakAllowed(). The new function performs some
additional checks to make sure it's an in-flow block level element. That
assumption could safely be made from apply{After,Before}Break(), but other call
sites shouldn't have to worry about such things.

Removed FIXME pair for something that was already working.

R=jchaffraix@chromium.org,leviw@chromium.org

Committed: https://crrev.com/77e28bf27545d7c9cc00a77bf81f4e5c2cbd22ed
Cr-Commit-Position: refs/heads/master@{#353021}

[leviw_travelin_and_unemployed, 2015-10-08 08:29:14]

https://codereview.chromium.org/1393673004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/1393673004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1806: bool checkPageBreaks =
!checkColumnBreaks && view()->layoutState()->pageLogicalHeight(); //
TODO(mstensho): Once columns can print, we have to check this.
Can you toss these TODO's on a different line?

https://codereview.chromium.org/1393673004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1816: bool checkPageBreaks =
!checkColumnBreaks && view()->layoutState()->pageLogicalHeight(); //
TODO(mstensho): Once columns can print, we have to check this.
Same as above.

https://codereview.chromium.org/1393673004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1817: bool checkAfterAlways
= (checkColumnBreaks && style()->columnBreakAfter() == PBALWAYS)
We should really rename these enums, unless we want to support pages that always
want peanut butter :p

[leviw_travelin_and_unemployed, 2015-10-08 08:29:21]

LGTM

[mstensho (USE GERRIT), 2015-10-08 08:29:46]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-10-08 08:29:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393673004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393673004/1

[commit-bot: I haz the power, 2015-10-08 08:34:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-08 08:34:46]

Patchset 1 (id:??) landed as
https://crrev.com/77e28bf27545d7c9cc00a77bf81f4e5c2cbd22ed
Cr-Commit-Position: refs/heads/master@{#353021}